From 60faa9052a74d7a6ac8db59dae2d7017542310d7 Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Fri, 12 Apr 2024 16:18:57 -0700 Subject: [PATCH] feat(libnpmversion)!: remove silent option BREAKING CHANGE: libnpmversion no longer takes a `silent` option to suppress output from `@npmcli/run-script`. That output is now emitted via an `output` event on `process`. --- workspaces/libnpmversion/README.md | 1 - workspaces/libnpmversion/lib/index.js | 2 -- workspaces/libnpmversion/lib/version.js | 1 - workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs | 2 -- 4 files changed, 6 deletions(-) diff --git a/workspaces/libnpmversion/README.md b/workspaces/libnpmversion/README.md index ac9ee50ae35d9..857c4d52dc183 100644 --- a/workspaces/libnpmversion/README.md +++ b/workspaces/libnpmversion/README.md @@ -31,7 +31,6 @@ npmVersion(arg, { ignoreScripts: false, // do not run pre/post/version lifecycle scripts scriptShell: '/bin/bash', // shell to run lifecycle scripts in message: 'v%s', // message for tag and commit, replace %s with the version - silent: false, // passed to @npmcli/run-script to control whether it logs }).then(newVersion => { console.error('version updated!', newVersion) }) diff --git a/workspaces/libnpmversion/lib/index.js b/workspaces/libnpmversion/lib/index.js index 95acd11b5e433..4d2fb45945a7b 100644 --- a/workspaces/libnpmversion/lib/index.js +++ b/workspaces/libnpmversion/lib/index.js @@ -15,7 +15,6 @@ module.exports = async (newversion, opts = {}) => { scriptShell = undefined, preid = null, message = 'v%s', - silent, } = opts const pkg = opts.pkg || await readJson(path + '/package.json') @@ -35,6 +34,5 @@ module.exports = async (newversion, opts = {}) => { preid, pkg, message, - silent, }) } diff --git a/workspaces/libnpmversion/lib/version.js b/workspaces/libnpmversion/lib/version.js index 71b55a21c2889..bfcd8a521496d 100644 --- a/workspaces/libnpmversion/lib/version.js +++ b/workspaces/libnpmversion/lib/version.js @@ -20,7 +20,6 @@ module.exports = async (newversion, opts) => { ignoreScripts, preid, pkg, - silent, } = opts const { valid, clean, inc } = semver diff --git a/workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs b/workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs index 59224e13fae45..07bf61461bb0b 100644 --- a/workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs +++ b/workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs @@ -24,7 +24,6 @@ Array [ "scriptShell": undefined, "signGitCommit": false, "signGitTag": false, - "silent": undefined, "tagVersionPrefix": "v", }, ] @@ -49,7 +48,6 @@ Array [ "scriptShell": "/bin/bash", "signGitCommit": true, "signGitTag": true, - "silent": undefined, "tagVersionPrefix": "=", }, ]