chore: rewrite doctor tests

npm · Mar 7, 2022 · 5f90d92 · 5f90d92
1 parent dc10418
commit 5f90d92
Show file tree

Hide file tree

Showing 9 changed files with 1,909 additions and 1,039 deletions.
diff --git a/lib/commands/doctor.js b/lib/commands/doctor.js
@@ -129,6 +129,7 @@ class Doctor extends BaseCommand {
     if (!this.npm.silent) {
       this.npm.output(table(outTable, tableOpts))
       if (!allOk) {
+        // TODO is this really needed?
         console.error('')
       }
     }

diff --git a/package-lock.json b/package-lock.json
@@ -167,6 +167,7 @@
         "@npmcli/template-oss": "^2.9.2",
         "eslint": "^8.3.0",
         "licensee": "^8.2.0",
+        "nock": "^13.2.4",
         "spawk": "^1.7.1",
         "tap": "^15.1.6"
       },
@@ -5331,14 +5332,14 @@
       }
     },
     "node_modules/nock": {
-      "version": "12.0.3",
-      "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
-      "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+      "version": "13.2.4",
+      "resolved": "https://registry.npmjs.org/nock/-/nock-13.2.4.tgz",
+      "integrity": "sha512-8GPznwxcPNCH/h8B+XZcKjYPXnUV5clOKCjAqyjsiqA++MpNx9E9+t8YPp0MbThO+KauRo7aZJ1WuIZmOrT2Ug==",
       "dev": true,
       "dependencies": {
         "debug": "^4.1.0",
         "json-stringify-safe": "^5.0.1",
-        "lodash": "^4.17.13",
+        "lodash.set": "^4.3.2",
         "propagate": "^2.0.0"
       },
       "engines": {
@@ -10435,21 +10436,6 @@
         "node": "^12.13.0 || ^14.15.0 || >=16"
       }
     },
-    "workspaces/arborist/node_modules/nock": {
-      "version": "13.2.1",
-      "resolved": "https://registry.npmjs.org/nock/-/nock-13.2.1.tgz",
-      "integrity": "sha512-CoHAabbqq/xZEknubuyQMjq6Lfi5b7RtK6SoNK6m40lebGp3yiMagWtIoYaw2s9sISD7wPuCfwFpivVHX/35RA==",
-      "dev": true,
-      "dependencies": {
-        "debug": "^4.1.0",
-        "json-stringify-safe": "^5.0.1",
-        "lodash.set": "^4.3.2",
-        "propagate": "^2.0.0"
-      },
-      "engines": {
-        "node": ">= 10.13"
-      }
-    },
     "workspaces/libnpmaccess": {
       "version": "6.0.0",
       "license": "ISC",
@@ -10468,6 +10454,21 @@
         "node": "^12.13.0 || ^14.15.0 || >=16"
       }
     },
+    "workspaces/libnpmaccess/node_modules/nock": {
+      "version": "12.0.3",
+      "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+      "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+      "dev": true,
+      "dependencies": {
+        "debug": "^4.1.0",
+        "json-stringify-safe": "^5.0.1",
+        "lodash": "^4.17.13",
+        "propagate": "^2.0.0"
+      },
+      "engines": {
+        "node": ">= 10.13"
+      }
+    },
     "workspaces/libnpmdiff": {
       "version": "4.0.0",
       "license": "ISC",
@@ -10622,6 +10623,21 @@
         "node": "^12.13.0 || ^14.15.0 || >=16"
       }
     },
+    "workspaces/libnpmorg/node_modules/nock": {
+      "version": "12.0.3",
+      "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+      "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+      "dev": true,
+      "dependencies": {
+        "debug": "^4.1.0",
+        "json-stringify-safe": "^5.0.1",
+        "lodash": "^4.17.13",
+        "propagate": "^2.0.0"
+      },
+      "engines": {
+        "node": ">= 10.13"
+      }
+    },
     "workspaces/libnpmpack": {
       "version": "4.0.0",
       "license": "ISC",
@@ -10639,21 +10655,6 @@
         "node": "^12.13.0 || ^14.15.0 || >=16"
       }
     },
-    "workspaces/libnpmpack/node_modules/nock": {
-      "version": "13.2.1",
-      "resolved": "https://registry.npmjs.org/nock/-/nock-13.2.1.tgz",
-      "integrity": "sha512-CoHAabbqq/xZEknubuyQMjq6Lfi5b7RtK6SoNK6m40lebGp3yiMagWtIoYaw2s9sISD7wPuCfwFpivVHX/35RA==",
-      "dev": true,
-      "dependencies": {
-        "debug": "^4.1.0",
-        "json-stringify-safe": "^5.0.1",
-        "lodash.set": "^4.3.2",
-        "propagate": "^2.0.0"
-      },
-      "engines": {
-        "node": ">= 10.13"
-      }
-    },
     "workspaces/libnpmpublish": {
       "version": "6.0.0",
       "license": "ISC",
@@ -10675,6 +10676,21 @@
         "node": "^12.13.0 || ^14.15.0 || >=16"
       }
     },
+    "workspaces/libnpmpublish/node_modules/nock": {
+      "version": "12.0.3",
+      "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+      "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+      "dev": true,
+      "dependencies": {
+        "debug": "^4.1.0",
+        "json-stringify-safe": "^5.0.1",
+        "lodash": "^4.17.13",
+        "propagate": "^2.0.0"
+      },
+      "engines": {
+        "node": ">= 10.13"
+      }
+    },
     "workspaces/libnpmsearch": {
       "version": "5.0.0",
       "license": "ISC",
@@ -10765,6 +10781,21 @@
         "node": "^12.13.0 || ^14.15.0 || >=16"
       }
     },
+    "workspaces/libnpmteam/node_modules/nock": {
+      "version": "12.0.3",
+      "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+      "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+      "dev": true,
+      "dependencies": {
+        "debug": "^4.1.0",
+        "json-stringify-safe": "^5.0.1",
+        "lodash": "^4.17.13",
+        "propagate": "^2.0.0"
+      },
+      "engines": {
+        "node": ">= 10.13"
+      }
+    },
     "workspaces/libnpmversion": {
       "version": "3.0.0",
       "license": "ISC",
@@ -11340,20 +11371,6 @@
         "tcompare": "^5.0.6",
         "treeverse": "^1.0.4",
         "walk-up-path": "^1.0.0"
-      },
-      "dependencies": {
-        "nock": {
-          "version": "13.2.1",
-          "resolved": "https://registry.npmjs.org/nock/-/nock-13.2.1.tgz",
-          "integrity": "sha512-CoHAabbqq/xZEknubuyQMjq6Lfi5b7RtK6SoNK6m40lebGp3yiMagWtIoYaw2s9sISD7wPuCfwFpivVHX/35RA==",
-          "dev": true,
-          "requires": {
-            "debug": "^4.1.0",
-            "json-stringify-safe": "^5.0.1",
-            "lodash.set": "^4.3.2",
-            "propagate": "^2.0.0"
-          }
-        }
       }
     },
     "@npmcli/ci-detect": {
@@ -14285,6 +14302,20 @@
         "npm-package-arg": "^9.0.0",
         "npm-registry-fetch": "^13.0.0",
         "tap": "^15.1.0"
+      },
+      "dependencies": {
+        "nock": {
+          "version": "12.0.3",
+          "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+          "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+          "dev": true,
+          "requires": {
+            "debug": "^4.1.0",
+            "json-stringify-safe": "^5.0.1",
+            "lodash": "^4.17.13",
+            "propagate": "^2.0.0"
+          }
+        }
       }
     },
     "libnpmdiff": {
@@ -14399,6 +14430,20 @@
         "nock": "^12.0.1",
         "npm-registry-fetch": "^13.0.0",
         "tap": "^15.0.0"
+      },
+      "dependencies": {
+        "nock": {
+          "version": "12.0.3",
+          "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+          "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+          "dev": true,
+          "requires": {
+            "debug": "^4.1.0",
+            "json-stringify-safe": "^5.0.1",
+            "lodash": "^4.17.13",
+            "propagate": "^2.0.0"
+          }
+        }
       }
     },
     "libnpmpack": {
@@ -14410,20 +14455,6 @@
         "npm-package-arg": "^9.0.0",
         "pacote": "^13.0.2",
         "tap": "^15.0.0"
-      },
-      "dependencies": {
-        "nock": {
-          "version": "13.2.1",
-          "resolved": "https://registry.npmjs.org/nock/-/nock-13.2.1.tgz",
-          "integrity": "sha512-CoHAabbqq/xZEknubuyQMjq6Lfi5b7RtK6SoNK6m40lebGp3yiMagWtIoYaw2s9sISD7wPuCfwFpivVHX/35RA==",
-          "dev": true,
-          "requires": {
-            "debug": "^4.1.0",
-            "json-stringify-safe": "^5.0.1",
-            "lodash.set": "^4.3.2",
-            "propagate": "^2.0.0"
-          }
-        }
       }
     },
     "libnpmpublish": {
@@ -14439,6 +14470,20 @@
         "semver": "^7.1.3",
         "ssri": "^8.0.1",
         "tap": "^15"
+      },
+      "dependencies": {
+        "nock": {
+          "version": "12.0.3",
+          "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+          "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+          "dev": true,
+          "requires": {
+            "debug": "^4.1.0",
+            "json-stringify-safe": "^5.0.1",
+            "lodash": "^4.17.13",
+            "propagate": "^2.0.0"
+          }
+        }
       }
     },
     "libnpmsearch": {
@@ -14507,6 +14552,20 @@
         "nock": "^12.0.1",
         "npm-registry-fetch": "^13.0.0",
         "tap": "^15"
+      },
+      "dependencies": {
+        "nock": {
+          "version": "12.0.3",
+          "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
+          "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+          "dev": true,
+          "requires": {
+            "debug": "^4.1.0",
+            "json-stringify-safe": "^5.0.1",
+            "lodash": "^4.17.13",
+            "propagate": "^2.0.0"
+          }
+        }
       }
     },
     "libnpmversion": {
@@ -14908,14 +14967,14 @@
       "integrity": "sha512-+EUsqGPLsM+j/zdChZjsnX51g4XrHFOIXwfnCVPGlQk/k5giakcKsuxCObBRu6DSm9opw/O6slWbJdghQM4bBg=="
     },
     "nock": {
-      "version": "12.0.3",
-      "resolved": "https://registry.npmjs.org/nock/-/nock-12.0.3.tgz",
-      "integrity": "sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==",
+      "version": "13.2.4",
+      "resolved": "https://registry.npmjs.org/nock/-/nock-13.2.4.tgz",
+      "integrity": "sha512-8GPznwxcPNCH/h8B+XZcKjYPXnUV5clOKCjAqyjsiqA++MpNx9E9+t8YPp0MbThO+KauRo7aZJ1WuIZmOrT2Ug==",
       "dev": true,
       "requires": {
         "debug": "^4.1.0",
         "json-stringify-safe": "^5.0.1",
-        "lodash": "^4.17.13",
+        "lodash.set": "^4.3.2",
         "propagate": "^2.0.0"
       }
     },

diff --git a/package.json b/package.json
@@ -204,6 +204,7 @@
     "@npmcli/template-oss": "^2.9.2",
     "eslint": "^8.3.0",
     "licensee": "^8.2.0",
+    "nock": "^13.2.4",
     "spawk": "^1.7.1",
     "tap": "^15.1.6"
   },