fix(read): change lstat to stat to correctly evaluate file size #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing something interesting with cacache, which could be made a lot more efficient if I could symlink files into the cache. This almost works.
However, the content reader uses a couple of
lstat
calls during integrity checking, which explicitly read details about the symlink and not it's target, returning the wrong sizes.Changing these calls to
stat
calls allows my plans to succeed, and shouldn't cause any harm to people not putting symlinks in their cacache.