This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: skip dep->targetEdge conflict check when placing if there is a current node #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: npm/cli#3881
When placing a peer set containing a dependency that could not be placed
higher in the tree due to a conflict, the entire peer set would get
nested even though the current node would satisfy the condition at the
target.
For example:
When placing
x
it would previously result in a tree withx
nestedunder
k
even though it can be properly hoisted to the root:After this patch the tree will now result in
x
being properly hoisted:Co-authored-by: @isaacs