Terminal.write() & console ANSI escape sequences

[emmercm]

I have a custom format function that makes heavy use of chalk coloring:

https://github.com/emmercm/igir/blob/1ba176d54877dc01aafe13df2abe57ddd6fb2926/src/console/singleBarFormatted.ts#L30

(see the Asciicast in the project's readme for a video of how it renders)

The default formatter takes into account ANSI escape sequences by using string-width to calculate the true width of a string, but this is only for alignment. Terminal.write() doesn't use string-width and instead trims all lines to process.stdout.columns.

[emmercm]

I think it's because MultiBar, which has its own Terminal instance, sets linewrap: false:

cli-progress/lib/multi-bar.js

Lines 67 to 70 in f4dc172

	// disable line wrapping ?
	if (this.options.linewrap === false){
	this.terminal.lineWrapping(false);
	}

but when it spawns new GenericBars:

cli-progress/lib/multi-bar.js

Lines 42 to 43 in f4dc172

	// create new bar element
	const bar = new _BarElement(Object.assign({}, this.options, barOptions));

those each get their own Terminal instance which default to linewrap: true:

cli-progress/lib/generic-bar.js

Line 16 in f4dc172

this.terminal = (this.options.terminal) ? this.options.terminal : new _Terminal(this.options.stream);

[AndiDittrich]

the hard-trimming within terminal.write was required to avoid issues on different platforms .. i know this might cause such issues - atm i've no "real "solution without adding a heavy library (slow!) which take the ascii sequences into account.

regarding the terminal instances: you're right, that looks weak .. i'm not shure why i've didn't passed the "global" instance to the generic bars. i've to take a look into

[emmercm]

You're right, I think my original post is incorrect here. I think it's because the linewrap setting isn't being respected for multi-bars.

[AndiDittrich]

i've applied the fix which uses the same terminal instance for all bars

[emmercm]

Confirmed that this fixed my issue! Sorry for the slow feedback.