Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to minervaclient? #23

Open
auryan898 opened this issue Jun 24, 2018 · 1 comment
Open

Improvements to minervaclient? #23

auryan898 opened this issue Jun 24, 2018 · 1 comment

Comments

@auryan898
Copy link

I wanted to suggest some improvements, such as:

  • A search subcommand to just find course information without needing a login
  • Publish minervaclient to Pypi for pip installation
  • Remove the necessity for a credentials_local.py
  • Convert your mix of tabs and spaces to just spaces

But as I went looking for these issues I kind of did them in my fork, assuming that you had set this project aside. This is the part where I say sorry that I took the name minervaclient from pip and uploaded my fork to it!

I was afraid to make a pull request too, because I made sooo many drastic changes to the code I didn't think you'd accept it. I still plan on making my own set of improvements, do you care for any kind of attribution? Should I stop? Love your work btw! It's the nicest 3rd party library I've seen so far that acesses Minerva services, and it actually works compared to the others!

@npaun
Copy link
Owner

npaun commented Jun 24, 2018

Sent you an email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants