[Proposal] Add IAM objects name override option #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperigault
force-pushed
the
ape/iam_names_override
branch
from
86f036c to
a62ee6a
Compare
|
Hi @npalm, |
npalm
requested changes
Aug 28, 2021
There was a problem hiding this comment.
@aperigault Still planning to update the module to a later TF version. But for now the easiest way to fix the format errors in CI. Is as follow. Install latest terraform 0.3.x (via tfenv). With tfenv you can easy switch between terraform verions.
Please can you fix the format errors?
Change lookds good to me
aperigault
force-pushed
the
ape/iam_names_override
branch
from
586af8b to
1c50232
Compare
|
CI is now ok but my terraform-docs do not generate same format. Do you use specific configuration or simply an older version ? |
npalm
approved these changes
Aug 30, 2021
semantic-releaser bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
## [4.30.0](4.29.0...4.30.0) (2021-08-30) ### Features * Add option to override IAM objects names ([#358](#358)) ([c96051d](c96051d))
|
🎉 This PR is included in version 4.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
that referenced
this pull request
Oct 4, 2021
## [4.30.0](4.29.0...4.30.0) (2021-08-30) ### Features * Add option to override IAM objects names ([#358](#358)) ([c96051d](c96051d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a new key
name_iam_objectsinoverridesmap to rename all IAM objects (instance profile, role and policies).Migrations required
NO, default values not change
Documentation
Ok