Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add amazon-ecr-credential-helper inside userdata_pre_install #311

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

dmitrijn
Copy link
Contributor

@dmitrijn dmitrijn commented Mar 6, 2021

closes:
#271
#308

Description

feat: add amazon-ecr-credential-helper inside userdata_pre_install
chore: update pre-commit-terraform and readme.md to latest version

Dmitrij Nikitenko added 2 commits March 6, 2021 13:59
…efault is false.

chore: update pre-commit-terraform and readme.md to latest version
@dmitrijn dmitrijn changed the title add amazon-ecr-credential-helper inside userdata_pre_install feat: add amazon-ecr-credential-helper inside userdata_pre_install Mar 6, 2021
@dmitrijn
Copy link
Contributor Author

dmitrijn commented Mar 9, 2021

@npalm could you check?

@npalm
Copy link
Collaborator

npalm commented Mar 9, 2021

@dmitrijn thanks for the reminder, will run a check later this week

Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitrijn thanks for the contribution! LGTM will be merged

@npalm npalm merged commit d6733c4 into cattle-ops:develop Mar 10, 2021
npalm pushed a commit that referenced this pull request Mar 10, 2021
)

* feat: add amazon-ecr-credential-helper inside userdata_pre_install, default is false.
chore: update pre-commit-terraform and readme.md to latest version


Co-authored-by: Dmitrij Nikitenko <[email protected]>
npalm pushed a commit that referenced this pull request Mar 10, 2021
)

* feat: add amazon-ecr-credential-helper inside userdata_pre_install, default is false.
chore: update pre-commit-terraform and readme.md to latest version


Co-authored-by: Dmitrij Nikitenko <[email protected]>
semantic-releaser bot pushed a commit that referenced this pull request Mar 10, 2021
## [4.24.0](4.23.0...4.24.0) (2021-03-10)

### Features

* add amazon-ecr-credential-helper inside userdata_pre_install ([#311](#311)) ([aa0c8b4](aa0c8b4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants