-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support document generation for workflows #523
Conversation
Sorry meant to open this in my fork repo, please ignore for now, I'm still working on it |
…ests for action/workflow separately
5147c56
to
b10780a
Compare
npalmGH-240 upgrade packages to remove vulnerabilities
…dditional helper scripts
npalmGH-240 update CONTRIBUTING where command does not work and add additi…
npalmGH-240 add option to have a top level header containing the name
I love when people open PR asap, this is a great way to share there is work being done on feature. The PR is in draft so all good! |
Thanks, it's so easy to do especially if you're not used to working with forks as you're not expecting the target branch to default to the original repo! 🙈 |
@npalm To let you know, I'm having some issues with megalinter. I've tried running it locally but there's an issue with @types/glob It's the same as this issue here: isaacs/rimraf#264
It's because I can see the megalinter workflow isn't passing on main so I assume that's still in progress and I'll ignore it for now |
@larmitage-bjss great PR, just had a bit more time to have a look. I would say in general fine. Would you have time to address my last comment. As well re-base with main. |
@npalm thanks very much, sorry I haven't updated in a while, I've been busy but should have some time to finish this off tomorrow |
I have also done this, keeping it backwards compatible for the readmes @npalm actually I think this is ready for re-review now, just let me know about this comment |
@@ -55,7 +55,9 @@ | |||
"@typescript-eslint/require-array-sort-compare": "error", | |||
"@typescript-eslint/restrict-plus-operands": "error", | |||
"@typescript-eslint/type-annotation-spacing": "error", | |||
"@typescript-eslint/unbound-method": "error" | |||
"@typescript-eslint/unbound-method": "error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you recall which lines are triggering this issue. Would prefer either fix the error, or at an ignore on the line. Not global.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was with adding enums causing an error already declared in the upper scope
Adding those two lines was as suggested here:
typescript-eslint/typescript-eslint#2466
@larmitage-bjss checked the PR again. Looks good, some minor left overs. |
Co-authored-by: Niek Palm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larmitage-bjss wow what a great job.
close #240 |
Adds functionality to be able to generate documentation for workflows as well as actions
Notes:
on
section, but as there are a lot of trigger events I think it would be best to do this separately (I will open an issue for this)