Fix kms_key_alias output #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
Also thanks for catching this as well. I'm not sure if how much it's actually useful to have an alias in the repliaca region though, still it seems a better choice to keep consistency between the main region and the replica region. |
|
Funny enough, after talking about it, I actually tried to apply the alias in the other region, and I was facing some problems. I'll be waiting for my other open PR to be merged and then I'll try again to apply the alias to the other region's KMS Key. |
yyxi
pushed a commit
to escapace/terraform-aws-terraform-backend
that referenced
this pull request
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the output of the KMS Key Alias, which currently output the same thing as the KMS Key itself.
PS: On a side note, the KMS Key Alias is not set on the KMS Key in the replica region.