-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Make preferences.default a nullable field #7068
Conversation
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
}), | ||
channels: channelsSchema, | ||
}) | ||
.nullable(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default
preferences isn't nullable, it should always be present. The default
preferences for Dashboard-sourced workflows will always be the DEFAULT_WORKFLOW_PREFERENCES
, whereas the default
preferences for Framework-sourced workflows are that defined in code.
What issue is this solving?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no default
preferences are supplied, the UpsertWorkflow
use-case falls back to DEFAULT_WORKFLOW_PREFERENCES
here. So instead, we should not send default
.
With the current API validation and implementation, there are no cases where Any cases where the |
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer