Bugfix: ArgumentNullException on iOS 14.5+ #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding this bug. This fixes the exception, but is not the correct ServiceName. There is a lot of different lingo around mDNS stuff, but essentially the ServiceName here should be the full unique name of the service. So like a printer will have _printer._tcp.local. as the service and the full name will be HP1FOO3BAR._printer._tcp.local. I didn't realize you had this request as I didn't see an issue related to it... and I had just created a similar PR #246 or else I would have worked off of yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceName property was never assigned so host.AddService(svc) throws ArgumentNullException.