This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Change deprecated classesDir for classesDirs #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead as Gradle 5 removes this property
pablisco
force-pushed
the
fix-deprecated-classesDir-property
branch
from
0872bfb
to
5f72e72
Compare
pablisco
changed the title
classesDir for classesDirs
|
The fix for this is easy actually. We should just use classesDirs instead. |
|
Silly me. I thought this was an issue. Didn't realize it was a PR 🤦♂️ haha 😂 I couldn't see why the CI was failing. There might be multiple usages of |
|
Moved into #169 as part of the upgrade |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classesDiris deprecated in Gradle 4.x and we should useclassesDirsinstead as Gradle 5.x removes this property.Without this change, Gradle complains about it if we use Gradle 5.x on the client:
Fixes #94