[WIP] New behaviour property to populate the virtual name #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new behaviour property that give the ability to populate the virtual name with something other than the title. The value of this new behaviour property can be either a property or a method of the model.
| if (!empty($this->_properties['populate_property'])) { | ||
| if (isset($item->{$this->_properties['populate_property']})) { | ||
| return $item->{$this->_properties['populate_property']}; | ||
| } elseif (method_exists($item, $this->_properties['populate_property'])) { |
There was a problem hiding this comment.
Would have done the other way around : give priority to method and then to property.
|
It needs to accept a closure to allow dynamic insertion of the behaviour imo. |
Indeed, using closure must be possible if methods added by behaviours are not recognized by "method_exists". |
|
@Meroje & @vrcAlbert 👍 |
1 similar comment
|
@Meroje & @vrcAlbert 👍 |
…regenerate after creation (eg. for populating an url with the item ID)
shaoshiva
changed the title
|
PR updated :
Todo: implement a mechanism in the renderer's javascript to observe fields and regenerate the virtual name when they change (currently only the title is observed). |
jguyomard
force-pushed
the
master/elche
branch
from
b52d845 to
9631c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new behaviour property that gives the ability to populate the virtual name with something other than the title. The value of this new behaviour property can be either a property or a method of the model.
Be careful, this new property will not affect the javascript part of the renderer that will always use the title to dynamically generates the virtual name.
To make it work with the renderer we need to rethink the way the virtual name is dynamically generated in javascript (eg. with an ajax call).