Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEC encoding explanation wrong? #12

Open
jinschoi opened this issue Apr 25, 2022 · 0 comments
Open

NEC encoding explanation wrong? #12

jinschoi opened this issue Apr 25, 2022 · 0 comments

Comments

@jinschoi
Copy link

Hi. I'm comparing your implementation against a captured bitstream and finding a discrepancy with your documentation.

According to this doc, the command is doubled with its logical inverse (bit flipped version), where you have it as simply reversed: 0x32 -> 0x3223. It should be 0x32cd. Your example encode is correct because the logical inverse of 0x78 is 0x87.

Actually, I just checked the code and it is implemented correctly! So it just the explanation that needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant