diff --git a/.github/workflows/cont_integration.yml b/.github/workflows/cont_integration.yml index a90d74667..128ba7251 100644 --- a/.github/workflows/cont_integration.yml +++ b/.github/workflows/cont_integration.yml @@ -10,32 +10,25 @@ jobs: strategy: matrix: rust: - - version: 1.67.0 # STABLE + - version: stable clippy: true - version: 1.57.0 # MSRV features: - --no-default-features - --all-features - - --features=default steps: - name: checkout uses: actions/checkout@v2 - - name: Generate cache key - run: echo "${{ matrix.rust.version }} ${{ matrix.features }}" | tee .cache_key - name: Install Rust toolchain uses: actions-rs/toolchain@v1 with: toolchain: ${{ matrix.rust.version }} override: true - components: clippy profile: minimal - name: Rust Cache uses: Swatinem/rust-cache@v2.2.1 - name: Build run: cargo build ${{ matrix.features }} - - name: Clippy - if: ${{ matrix.rust.clippy }} - run: cargo clippy --all-targets ${{ matrix.features }} -- -D warnings - name: Test run: cargo test ${{ matrix.features }} @@ -56,7 +49,7 @@ jobs: - name: Install Rust toolchain uses: actions-rs/toolchain@v1 with: - toolchain: "1.65.0" + toolchain: stable override: true profile: minimal target: "wasm32-unknown-unknown" @@ -78,9 +71,27 @@ jobs: - name: Install Rust toolchain uses: actions-rs/toolchain@v1 with: - toolchain: "1.65.0" + toolchain: stable override: true profile: minimal components: rustfmt - name: Check fmt run: cargo fmt --all -- --config format_code_in_doc_comments=true --check + + clippy_check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: actions-rs/toolchain@v1 + with: + # we pin clippy instead of using "stable" so that our CI doesn't break + # at each new cargo release + toolchain: "1.67.0" + components: clippy + override: true + - name: Rust Cache + uses: Swatinem/rust-cache@v2.2.1 + - uses: actions-rs/clippy-check@v1 + with: + token: ${{ secrets.GITHUB_TOKEN }} + args: --all-features --all-targets -- -D warnings diff --git a/crates/bdk/src/wallet/mod.rs b/crates/bdk/src/wallet/mod.rs index 053bf8a66..67032cd3c 100644 --- a/crates/bdk/src/wallet/mod.rs +++ b/crates/bdk/src/wallet/mod.rs @@ -1408,7 +1408,6 @@ impl Wallet { /// Given the options returns the list of utxos that must be used to form the /// transaction and any further that may be used if needed. - #[allow(clippy::type_complexity)] #[allow(clippy::too_many_arguments)] fn preselect_utxos( &self,