Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ACK handler #36

Open
vuong177 opened this issue Jan 13, 2023 · 6 comments
Open

Separate ACK handler #36

vuong177 opened this issue Jan 13, 2023 · 6 comments
Assignees

Comments

@vuong177
Copy link
Contributor

We have two separate ACK: query price ack and swap token ack. We need to separate it in OnAcknowledgementPacket.

@GNaD13
Copy link
Contributor

GNaD13 commented Jan 13, 2023

Hey, I already setup for this in #30,can you check it?

@GNaD13
Copy link
Contributor

GNaD13 commented Jan 18, 2023

We have two separate ACK: query price ack and swap token ack. We need to separate it in OnAcknowledgementPacket.

No need now because we can use osmosis cross-chain swap instead

@vuong177
Copy link
Contributor Author

yes

@GNaD13 GNaD13 reopened this Feb 1, 2023
@GNaD13
Copy link
Contributor

GNaD13 commented Feb 1, 2023

reopen because now we need to handle swap on axelar, there are 2 choice:

  • using feeabs ibc msg
  • ICA Controller msg

@GNaD13
Copy link
Contributor

GNaD13 commented Feb 1, 2023

@expertdicer I think we need to check enum msg on contract so we can handle these type of msg

@expertdicer
Copy link
Contributor

expertdicer commented Feb 1, 2023

@expertdicer I think we need to check enum msg on contract so we can handle these type of msg

Yes. I have made some works on enum msg with one of protobuf. Can you specify what kinds of msg ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants