-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notify-debouncer-full
/ -mini
always enable notify
default features
#549
Labels
Comments
LeoniePhiline
changed the title
Nov 22, 2023
notify-debouncer-full
always enables notify
default featuresnotify-debouncer-full
/ -mini
always enable notify
default features
LeoniePhiline
added a commit
to LeoniePhiline/notify
that referenced
this issue
Nov 22, 2023
Debouncers used to install `crossbeam-channel`, due to keeping `notify`'s default features enabled even if their own default features were disabled. With this change, `crossbeam-channel` will no longer be installed if `notify-debouncer-*` as well as `notify` are installed with `default-features = false` Fixes notify-rs#549
LeoniePhiline
added a commit
to LeoniePhiline/notify
that referenced
this issue
Nov 23, 2023
Debouncers used to install `crossbeam-channel`, due to keeping `notify`'s default features enabled even if their own default features were disabled. With this change, `crossbeam-channel` will no longer be installed if `notify-debouncer-*` as well as `notify` are installed with `default-features = false` Fixes notify-rs#549
LeoniePhiline
added a commit
to LeoniePhiline/notify
that referenced
this issue
Nov 23, 2023
Debouncers used to install `crossbeam-channel`, due to keeping `notify`'s default features enabled even if their own default features were disabled. With this change, `crossbeam-channel` will no longer be installed if `notify-debouncer-*` as well as `notify` are installed with `default-features = false` Fixes notify-rs#549
Merged
0xpr03
pushed a commit
that referenced
this issue
Jan 4, 2024
Debouncers used to install `crossbeam-channel`, due to keeping `notify`'s default features enabled even if their own default features were disabled. With this change, `crossbeam-channel` will no longer be installed if `notify-debouncer-*` as well as `notify` are installed with `default-features = false` Fixes #549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System details
rustc --version
: 1.74.0What you did (as detailed as you can)
notify
without default features.crossbeam-channel
is not installed (as expected).notify-debouncer-full
without default features.What you expected
crossbeam-channel
still not being installed, as default features are disabled for bothnotify
andnotify-debouncer-full
.What happened
crossbeam-channel
is now installed despite thecrossbeam
default feature being disabled.The reason is that
notify-debouncer-full
does not setdefault-features = false
on itsnotify
dependency.Steps to reproduce
Proposed fix
notify-debouncer-full/Cargo.toml
:Note: The same applies to
notify-debouncer-mini
.The text was updated successfully, but these errors were encountered: