Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with assertQueryStringHas() #78

Open
iadambrown opened this issue Feb 9, 2018 · 0 comments
Open

Issue with assertQueryStringHas() #78

iadambrown opened this issue Feb 9, 2018 · 0 comments

Comments

@iadambrown
Copy link
Collaborator

Just a heads up for anyone going through the last module, it seems there's an issue with the assertQueryStringHas assertion, due to a change to the assertHasQueryStringParameter method that it calls. Basically, assertHasQueryStringParameter now returns $this (i.e. the Laravel\Dusk\Browser object) instead of the $output array which contains the query string key/value pairs.

So having something like $browser->assertQueryStringHas('response_type', 'code') will cause a "Error: Cannot use object of type Laravel\Dusk\Browser as array" error when it gets to this part of the assertQueryStringHas method:

PHPUnit::assertEquals(
    $value, $output[$name],
    "Query string parameter [{$name}] had value [{$output[$name]}], but expected [{$value}]."
);

I've opened an issue here: laravel/dusk#455.

Here's the commit that causes the issue: laravel/dusk@fb67e61

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant