Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: upgrade notation-go to v1.0.0 #754

Merged
merged 3 commits into from
Jul 28, 2023
Merged

bump: upgrade notation-go to v1.0.0 #754

merged 3 commits into from
Jul 28, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Jul 27, 2023 •
edited
Loading

@shizhMSFT shizhMSFT marked this pull request as ready for review July 27, 2023 02:17
@shizhMSFT shizhMSFT added this to the 1.0.0 milestone Jul 27, 2023
@shizhMSFT shizhMSFT added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 27, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 27, 2023
Closed
15 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #754 (820c916) into main (cd92b23) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          40       40           
  Lines        2252     2252           
=======================================
  Hits         1441     1441           
  Misses        689      689           
  Partials      122      122

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JeyJeyGao
JeyJeyGao approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit f28cf32 into notaryproject:main Jul 28, 2023
@shizhMSFT shizhMSFT deleted the upgrade_dep branch July 28, 2023 01:59
@shizhMSFT shizhMSFT mentioned this pull request Jul 31, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Notary Project Planning Board
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shizhMSFT @codecov-commenter @priteshbandi @JeyJeyGao @Two-Hearts