Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimum(user only) file permissions #453

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

priteshbandi
Copy link
Contributor

Since we are not implementing system config behavior in rc1, updating code to have only user(r,w,x) permission.
Also, its a good practice to use minimum permission model

Signed-off-by: Pritesh Bandi [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #453 (4c2041a) into main (53052a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   32.82%   32.82%           
=======================================
  Files          25       25           
  Lines        1237     1237           
=======================================
  Hits          406      406           
  Misses        819      819           
  Partials       12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to revisit them when we consider system config again.

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Nov 25, 2022

@priteshbandi Could you edit the PR titles to conform with the conventional commit spec?

@yizha1
Copy link
Contributor

yizha1 commented Nov 25, 2022

An example of conventional commit https://github.com/oras-project/community/blob/main/GIT_CONVENTIONS.md

@priteshbandi priteshbandi changed the title Updates to use minimum file permissions Use minimum(user only) file permissions Nov 28, 2022
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 236efca into notaryproject:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants