Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when default signing key is not set #432

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Improve error message when default signing key is not set #432

merged 2 commits into from
Nov 7, 2022

Conversation

priteshbandi
Copy link
Contributor

Fixes Issue: #410

Test output

➜  notation git:(fix) ✗ ./notation key ls
NAME   KEY PATH   CERTIFICATE PATH   ID   PLUGIN NAME
➜  notation git:(fix) ✗ ./notation sign --plain-http $IMAGE
Error: default signing key not set. Please set default singing key or specify a key name

@priteshbandi priteshbandi mentioned this pull request Nov 4, 2022
Closed
shizhMSFT
shizhMSFT reviewed Nov 4, 2022
View reviewed changes
pkg/configutil/util.go Outdated Show resolved Hide resolved
addressing feedbacks
d86b039 
Signed-off-by: Pritesh Bandi <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022 •
edited
Loading

Codecov Report

Merging #432 (d86b039) into main (ed5beb8) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   32.95%   32.82%   -0.14%     
==========================================
  Files          25       25              
  Lines        1232     1237       +5     
==========================================
  Hits          406      406              
- Misses        814      819       +5     
  Partials       12       12
Impacted Files Coverage Δ
pkg/configutil/util.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shizhMSFT
shizhMSFT approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 40973f9 into notaryproject:main Nov 7, 2022
@shizhMSFT shizhMSFT mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@rgnote rgnote rgnote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priteshbandi @codecov-commenter @rgnote @shizhMSFT