Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a note for dependencies in go.mod file. #309

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Aug 19, 2022

Add a note to remind updating the dependencies in go.mod file before starting the release process.

Signed-off-by: Yi Zha [email protected]

@yizha1 yizha1 requested review from iamsamirzon and a team August 19, 2022 03:15
@iamsamirzon iamsamirzon requested a review from vaninrao10 August 22, 2022 19:30
@iamsamirzon
Copy link
Contributor

@yizha1 - Should we also call out the need for oras-go dependency in this? Also, do you want to mention the process to follow for releasing the notation-go and notation-go-core in this same file?

@yizha1
Copy link
Contributor Author

yizha1 commented Aug 24, 2022

@yizha1 - Should we also call out the need for oras-go dependency in this? Also, do you want to mention the process to follow for releasing the notation-go and notation-go-core in this same file?

Thanks Samir. I will add oras-go part. I don't think we need to mention the process for go libraries since the process is basically the official Github release process.

@yizha1 yizha1 requested a review from shizhMSFT September 2, 2022 06:52
@codecov-commenter
Copy link

Codecov Report

Merging #309 (5a364a1) into main (e73bfc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   30.66%   30.66%           
=======================================
  Files          25       25           
  Lines        1611     1611           
=======================================
  Hits          494      494           
  Misses       1104     1104           
  Partials       13       13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1
Copy link
Contributor Author

yizha1 commented Sep 20, 2022

@iamsamirzon @vaninrao10 Can you help to review this PR?

@dtzar dtzar merged commit 6e8e9c5 into main Oct 4, 2022
@dtzar dtzar deleted the release_checklist branch October 4, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants