Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS use of Notary CLI fails due to lack of developer verification #431

Closed
toddysm opened this issue Nov 4, 2022 · 10 comments
Closed
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@toddysm
Copy link
Contributor

toddysm commented Nov 4, 2022

After downloading notation CLI from the releases, starting it failed with error that developer cannot be verified. The workaround is to allow the binary in the security settings but even then another prompt is shown to confirm that the user wants to run it.

We need to improve the experience for Mac OS developers.

@toddysm
Copy link
Contributor Author

toddysm commented Nov 7, 2022

The best approach we can take for installation on Mac is to use Brew. Installation via Brew will avoid users seeing security prompts suggesting deleting the binary.

@priteshbandi priteshbandi added this to the Future milestone Nov 23, 2022
@priteshbandi
Copy link
Contributor

Other way to handle this is start singing binary for macOS

@yizha1
Copy link
Contributor

yizha1 commented Feb 22, 2023

Update the milestone to rc-3 based on the discussion.

@yizha1 yizha1 modified the milestones: future, RC-3 Feb 22, 2023
@yizha1 yizha1 added the help wanted Extra attention is needed label Feb 22, 2023
@mintbomb27
Copy link
Contributor

I kinda looked into this, and what I found was that as per the two ways to go about this:

  1. To sign the binaries, we'll need an Apple Developer Program account, and we can follow the procedure at https://developer.apple.com/developer-id/ , and can even get the binary notarized.
  2. Using homebrew we can either create a third party repository for homebrew, aka a tap. Through which the users will be able to install using brew tap org/repo and brew install notation, or else we can submit a PR to https://github.com/Homebrew/homebrew-core/ so that its not a third party repo.

I don't have an ADP account currently, but I'm free to take up the homebrew method mentioned if y'all agree with it. @yizha1 @toddysm

@yizha1
Copy link
Contributor

yizha1 commented Feb 26, 2023

@mintbomb27 Thanks. IMO the 2nd option is the way to go. Adding @shizhMSFT @FeynmanZhou for comments.

@FeynmanZhou
Copy link
Member

@mintbomb27 Hi, the 2nd is doable. I think you can follow the guideline of https://docs.brew.sh/Adding-Software-to-Homebrew to complete this submission. I also raised a separate issue #571 to track this plan.

However, Homebrew only allows accepting a stable release package and any alpha/RC release is not acceptable. So we still need to defer this implementation until a stable Notation CLI v1.0.0 release is available, which is mid of Apr. Before v1.0.0, we need to provide a workaround in a document for installing Notation on macOS.

How about we assign #571 to you first?

@mintbomb27
Copy link
Contributor

Sure, please go ahead. @FeynmanZhou

@yizha1
Copy link
Contributor

yizha1 commented May 4, 2023

duplicated with #571

@yizha1
Copy link
Contributor

yizha1 commented May 5, 2023

@toddysm can we close this one as duplicated with #571

@toddysm
Copy link
Contributor Author

toddysm commented May 8, 2023

Sure, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

5 participants