Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When no key is present, make key add be the default key #410

Closed
dtzar opened this issue Oct 21, 2022 · 5 comments
Closed

When no key is present, make key add be the default key #410

dtzar opened this issue Oct 21, 2022 · 5 comments
Assignees
Labels
bug Something isn't working UX User experience changes
Milestone

Comments

@dtzar
Copy link
Contributor

dtzar commented Oct 21, 2022

If there are no keys present for notation and you successfully add a key via notation key add <key> it does not make this key the default key and hence when you try to sign something it gives this: Error: signing key not found

We should add a check that if there are no keys present, we make the key added the default key without having to pass the --default flag.

@dtzar dtzar added bug Something isn't working UX User experience changes labels Oct 21, 2022
@dtzar dtzar added this to the RC-1 milestone Oct 21, 2022
@yizha1
Copy link
Contributor

yizha1 commented Nov 4, 2022

@dtzar Can this issue be addressed post-rc.1?

@priteshbandi
Copy link
Contributor

priteshbandi commented Nov 4, 2022

The experience is right but the error message is wrong. Error should say default signing key not set. Please set default singing key or specify a key name.

@yizha1
Copy link
Contributor

yizha1 commented Nov 4, 2022

The experience is right but the error message is wrong. Error should say default signing key not set. Please set default singing key or specify a key name.

Could there be a quick fix for the error message? I am not sure if the error is printed out from CLI or library

@priteshbandi
Copy link
Contributor

Yes, posted PR #432

@priteshbandi
Copy link
Contributor

PR had been merged, closing the issue.

Repository owner moved this from Todo to Done in Notary Project Planning Board Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX User experience changes
Projects
Status: Done
Development

No branches or pull requests

3 participants