Improve error message when default signing key is not set

notaryproject · Nov 4, 2022 · a71b7d0 · a71b7d0
1 parent ed5beb8
commit a71b7d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/cmd/notation/notation b/cmd/notation/notation
diff --git a/pkg/configutil/util.go b/pkg/configutil/util.go
@@ -34,9 +34,18 @@ func ResolveKey(name string) (config.KeySuite, error) {
 	if err != nil {
 		return config.KeySuite{}, err
 	}
+
+	// if name is empty, look for default signing key
 	if name == "" {
 		name = signingKeys.Default
 	}
+
+	// if name is still empty, return error
+	if name == "" {
+		return config.KeySuite{}, errors.New("default signing key not set." +
+			" Please set default singing key or specify a key name")
+	}
+
 	idx := slices.Index(signingKeys.Keys, name)
 	if idx < 0 {
 		return config.KeySuite{}, ErrKeyNotFound