Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix&bump: maintenance update for branch release-1.1 #448

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Sep 2, 2024

For maintaining release-1.1 branch:

Fix:

  • updated SigningAgent to be "notation-go/v1.1.2+unreleased"
  • updated codecov workflow to include secret for updating coverage statistic

Bump:

  • updated dependencies
  • updated Golang v1.22

@JeyJeyGao JeyJeyGao changed the base branch from main to release-1.1 September 2, 2024 05:53
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.1@94a0e13). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.1     #448   +/-   ##
==============================================
  Coverage               ?   80.19%           
==============================================
  Files                  ?       31           
  Lines                  ?     2101           
  Branches               ?        0           
==============================================
  Hits                   ?     1685           
  Misses                 ?      288           
  Partials               ?      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao changed the title fix: update branch release-1.1 fix: maintenance update for branch release-1.1 Sep 2, 2024
@JeyJeyGao JeyJeyGao changed the title fix: maintenance update for branch release-1.1 fix&bump: maintenance update for branch release-1.1 Sep 2, 2024
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao and others added 4 commits September 3, 2024 11:15
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao merged commit 0989bf5 into notaryproject:release-1.1 Sep 3, 2024
9 checks passed
@JeyJeyGao JeyJeyGao mentioned this pull request Sep 5, 2024
6 tasks
JeyJeyGao added a commit that referenced this pull request Sep 9, 2024
## Release

This would mean tagging 595c710
`v1.1.2` to release.

## Vote

We need at least `4` approvals from `6` maintainers to release
`notation-go v1.1.2`.

- [x] Pritesh Bandi (@priteshbandi)
- [x] Junjie Gao (@JeyJeyGao)
- [ ] Rakesh Gariganti (@rgnote)
- [ ] Milind Gokarn (@gokarnm)
- [x] Shiwei Zhang (@shizhMSFT)
- [x] Patrick Zheng (@Two-Hearts)


## What's Changed
* fix&bump: maintenance update for branch `release-1.1` by @JeyJeyGao in
#448
* fix: dir no longer panics when HOME and XDG_CONFIG_HOME are not set
(#449) by @JeyJeyGao in
#450


**Full Changelog**:
v1.1.1...595c710

## Actions

Please review the PR and vote by approving.

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao mentioned this pull request Sep 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants