Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove blob sign/verify related code #437

Merged
merged 12 commits into from
Aug 16, 2024
Merged

refactor!: remove blob sign/verify related code #437

merged 12 commits into from
Aug 16, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Aug 14, 2024 •
edited
Loading

As discussed, this PR removes the blob sign/verify related code for v1.2.0 release.

This PR targets on branch release-1.2 ONLY.

@Two-Hearts
removed blob sign/verify
41de3ab 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated comments
093e9d0 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update for v1.2.0-rc.1 release
4c12061 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update for v1.2.0-rc.1 release
ea2eacc 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (3c5a659) to head (d5e876a).
Report is 1 commits behind head on release-1.2.

Files Patch % Lines
verifier/verifier.go 82.35% 2 Missing and 1 partial ⚠️
verifier/trustpolicy/oci.go 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.2     #437      +/-   ##
===============================================
+ Coverage        80.86%   81.21%   +0.34%     
===============================================
  Files               33       32       -1     
  Lines             2483     2279     -204     
===============================================
- Hits              2008     1851     -157     
+ Misses             332      299      -33     
+ Partials           143      129      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao reviewed Aug 14, 2024
View reviewed changes
verifier/trustpolicy/oci.go Outdated Show resolved Hide resolved
verifier/trustpolicy/oci.go Outdated Show resolved Hide resolved
@Two-Hearts Two-Hearts requested a review from JeyJeyGao August 14, 2024 05:53
JeyJeyGao
JeyJeyGao previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
update for v1.2.0-rc.1 release
2574460 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
update for v1.2.0-rc.1 release
6702623 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao August 14, 2024 07:27
JeyJeyGao
JeyJeyGao previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title refactor!: removed blob sign/verify related code for v1.2.0 release refactor!: remove blob sign/verify related code Aug 14, 2024
@Two-Hearts
updated per code review
a7ba8fd 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
updated for v1.2.0 release
1b66429 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts dismissed stale reviews from shizhMSFT and JeyJeyGao via 1b66429 August 15, 2024 03:10
@Two-Hearts Two-Hearts mentioned this pull request Aug 15, 2024
Merged
JeyJeyGao
JeyJeyGao previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Aug 15, 2024
View reviewed changes
signer/signer.go Outdated Show resolved Hide resolved
@Two-Hearts
update signingAgent
f11626a 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT mentioned this pull request Aug 15, 2024
Closed
@Two-Hearts
update signingAgent
d5e876a 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit a83c5be into notaryproject:release-1.2 Aug 16, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the release branch August 16, 2024 02:13
@Two-Hearts Two-Hearts mentioned this pull request Aug 16, 2024
Closed
6 tasks
vaninrao10
vaninrao10 reviewed Aug 19, 2024
View reviewed changes
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the changes it is LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaninrao10 vaninrao10 vaninrao10 left review comments

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao @vaninrao10