Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: update revocation based on notation-core-go #429

Merged
merged 13 commits into from
Aug 14, 2024
Merged

refactor!: update revocation based on notation-core-go #429

merged 13 commits into from
Aug 14, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jul 31, 2024 •
edited
Loading

This PR makes refactoring of revocation with the updated notation-core-go.

@Two-Hearts
updated revocation
b79412a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
8a81760 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated revocation
5354b7c 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
1b70bfe 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (c3b2f51) to head (9340a5f).

Files Patch % Lines
verifier/verifier.go 92.40% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   80.74%   80.86%   +0.12%     
==========================================
  Files          33       33              
  Lines        2457     2483      +26     
==========================================
+ Hits         1984     2008      +24     
- Misses        331      332       +1     
- Partials      142      143       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts Two-Hearts added this to the 1.2.0 milestone Jul 31, 2024
@Two-Hearts Two-Hearts added the enhancement New feature or request label Jul 31, 2024
@Two-Hearts
update
b6429fb 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts removed the enhancement New feature or request label Aug 1, 2024
@Two-Hearts
update
02ac12e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts mentioned this pull request Aug 1, 2024
Merged
JeyJeyGao
JeyJeyGao reviewed Aug 6, 2024
View reviewed changes
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Aug 6, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
20fb2f1 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated per code review
26eec66 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Aug 6, 2024
View reviewed changes
verifier/verifier.go Outdated Show resolved Hide resolved
@Two-Hearts Two-Hearts requested a review from shizhMSFT August 8, 2024 02:37
@Two-Hearts Two-Hearts requested a review from JeyJeyGao August 8, 2024 02:37
JeyJeyGao
JeyJeyGao previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts requested a review from rgnote August 12, 2024 01:01
@Two-Hearts Two-Hearts mentioned this pull request Aug 12, 2024
Closed
@Two-Hearts Two-Hearts dismissed stale reviews from shizhMSFT and JeyJeyGao via 9340a5f August 12, 2024 01:28
JeyJeyGao
JeyJeyGao approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Aug 13, 2024
Closed
Open
rgnote
rgnote approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 3c5a659 into notaryproject:main Aug 14, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the revocation branch August 14, 2024 00:47
@Two-Hearts Two-Hearts mentioned this pull request Aug 16, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@rgnote rgnote rgnote approved these changes

@shizhMSFT shizhMSFT shizhMSFT left review comments

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @rgnote @shizhMSFT @JeyJeyGao @yizha1