Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validations for timestamp response #13

Closed
priteshbandi opened this issue Oct 1, 2021 · 6 comments
Closed

Add more validations for timestamp response #13

priteshbandi opened this issue Oct 1, 2021 · 6 comments
Labels
Stale triage Needs evaluation for feasibility, timeline, etc.

Comments

@priteshbandi
Copy link
Contributor

We do need to add more validation for timestamp response to avoid MitM, replay, etc. attacks and also to be a compliant client. The validations are more from timestamp security and correctness perspective. If the timestamp signature is bad then it is of no use for users.

Haven't gone through complete rfc3161 but here are some notable mentions:

Originally posted by @priteshbandi in #11 (comment)

@iamsamirzon iamsamirzon added this to the alpha-2 milestone Oct 12, 2021
@dtzar dtzar added the triage Needs evaluation for feasibility, timeline, etc. label Jul 11, 2022
@iamsamirzon
Copy link
Contributor

@shizhMSFT - could you consider this as part of the timestamping work your were looking at?
cc: @dtzar

@dtzar
Copy link
Contributor

dtzar commented Jul 13, 2022

IMO it makes sense for one engineer to own/drive all the items related to this space. See the linked roadmap item 59. I don't think this is owned by @shizhMSFT at this time. Perhaps @priteshbandi since you've been most involved and recently with this code and all three of these issues have been created by you?

@iamsamirzon iamsamirzon modified the milestones: alpha-2, RC-1 Jul 14, 2022
@vaninrao10 vaninrao10 modified the milestones: RC-1, RC-2 Oct 3, 2022
@vaninrao10
Copy link

As per the meeting note on sep, 19th "https://hackmd.io/_vrqBGAOSUC_VWvFzWruZw?view#Sep-19-2022 " this will be moved to RC-2 similar to notaryproject/roadmap#59

@priteshbandi
Copy link
Contributor Author

Removing RC2 milestone as its been tracked in parent issue notaryproject/roadmap#59

@priteshbandi priteshbandi removed this from the RC-2 milestone Nov 23, 2022
Copy link

This issue is stale because it has been opened for 60 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 20, 2024
Copy link

Issue closed due to no activity in the past 30 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale triage Needs evaluation for feasibility, timeline, etc.
Projects
Status: Done
Development

No branches or pull requests

4 participants