fix(test): test cases with example.com URL

[JeyJeyGao]

Fix:

• added mocked HTTP client for a test case of revocation package
• replaced *.com with *.test to avoid mentioning a real domain in testing URL

NOTE: .test is a reserved domain for testing in RFC 2606

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (3067ab1) to head (1c112ba).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   91.89%   91.29%   -0.61%     
==========================================
  Files          30       30              
  Lines        2074     2608     +534     
==========================================
+ Hits         1906     2381     +475     
- Misses        114      173      +59     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Two-Hearts]

I would suggest replacing any real URLs in test files with fake ones even though we are mocking the servers. This is to avoid future mistaken tests that a developer forgot to mock the server and a real roundtrip got sent out.

[JeyJeyGao]

I would suggest replacing any real URLs in test files with fake ones even though we are mocking the servers. This is to avoid future mistaken tests that a developer forgot to mock the server and a real roundtrip got sent out.

How can we ensure the URL is fake? Maybe the fake one will be registered by someone else later.

[JeyJeyGao]

I would suggest replacing any real URLs in test files with fake ones even though we are mocking the servers. This is to avoid future mistaken tests that a developer forgot to mock the server and a real roundtrip got sent out.

Replaced example.com with example.fake

[Two-Hearts]

How can we ensure the URL is fake? Maybe the fake one will be registered by someone else later.

Oh, I was thinking we are mocking the server using https://pkg.go.dev/net/http/httptest#Server. Then we could use the server.URL directly, turns out we are mocking the http client transport.

Yeah, as Shiwei suggested below, .test is probably a better option for us.

[shizhMSFT]

@JeyJeyGao RFC 2606 defines some safer domains (see https://datatracker.ietf.org/doc/html/rfc2606#section-2)

[JeyJeyGao]

@JeyJeyGao RFC 2606 defines some safer domains (see https://datatracker.ietf.org/doc/html/rfc2606#section-2)

Updated the URL to be localhost.test

[Two-Hearts]

LGTM

[shizhMSFT]

What about uncached.com?

[JeyJeyGao]

What about uncached.com?

Nice catch! Updated.

[shizhMSFT]

LGTM

[Two-Hearts]

LGTM

[priteshbandi]

LGTM