Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: update revocation #215

Merged
merged 25 commits into from
Aug 8, 2024
Merged

refactor!: update revocation #215

merged 25 commits into from
Aug 8, 2024

Conversation

Two-Hearts
Copy link
Contributor

This PR updates the revocation package before v1.1.0 stable release. It makes the package more extensible.

@Two-Hearts
refactored revocation
e218e8f 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fixed license
bba1705 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (45dcf46) to head (02ab652).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   90.88%   91.05%   +0.16%     
==========================================
  Files          26       26              
  Lines        1778     1789      +11     
==========================================
+ Hits         1616     1629      +13     
+ Misses        112      111       -1     
+ Partials       50       49       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT reviewed Jul 29, 2024
View reviewed changes
revocation/x509/cert.go Outdated Show resolved Hide resolved
revocation/revocation.go Outdated Show resolved Hide resolved
@Two-Hearts Two-Hearts changed the title feat: update revocation refactor!: update revocation Jul 29, 2024
@Two-Hearts
updated per code review
b886f0a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from shizhMSFT July 29, 2024 09:03
@Two-Hearts
fix
dc24a75 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix
dadec5f 
Signed-off-by: Patrick Zheng <[email protected]>
@yizha1 yizha1 added this to the 1.2.0 milestone Jul 30, 2024
JeyJeyGao
JeyJeyGao reviewed Jul 30, 2024
View reviewed changes
revocation/revocation.go Outdated Show resolved Hide resolved
@Two-Hearts
update
73d64c8 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao July 30, 2024 02:56
JeyJeyGao
JeyJeyGao reviewed Jul 30, 2024
View reviewed changes
revocation/revocation.go Show resolved Hide resolved
revocation/revocation.go Show resolved Hide resolved
@Two-Hearts
update
56447bd 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
254c50c 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
fix
e19d36b 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Jul 30, 2024
View reviewed changes
revocation/ocsp/ocsp.go Outdated Show resolved Hide resolved
revocation/revocation.go Outdated Show resolved Hide resolved
revocation/revocation.go Outdated Show resolved Hide resolved
revocation/revocation.go Outdated Show resolved Hide resolved
@Two-Hearts
update
442f510 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from shizhMSFT August 6, 2024 01:54
JeyJeyGao
JeyJeyGao previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
update
3ca469d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao August 6, 2024 05:50
@Two-Hearts
Revert "update"
8a09715 
This reverts commit 3ca469d.

Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
updated per discussions
6166ff2 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts dismissed stale reviews from shizhMSFT and JeyJeyGao via 6166ff2 August 7, 2024 03:39
@Two-Hearts
updated per discussions
67f085a 
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
priteshbandi previously approved these changes Aug 7, 2024
View reviewed changes
@Two-Hearts
updated per discussions
02ab652 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from priteshbandi August 7, 2024 03:51
shizhMSFT
shizhMSFT approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 004b86d into notaryproject:main Aug 8, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the revocation branch August 8, 2024 01:50
JeyJeyGao added a commit to JeyJeyGao/notation-core-go that referenced this pull request Aug 8, 2024
@JeyJeyGao
Squashed commit of the following:
281dd64 
commit 004b86d
Author: Patrick Zheng <[email protected]>
Date:   Thu Aug 8 09:50:12 2024 +0800

    refactor!: update revocation (notaryproject#215)

    Signed-off-by: Patrick Zheng <[email protected]>

Signed-off-by: Junjie Gao <[email protected]>
@vaninrao10
Copy link

LGTM

@Two-Hearts Two-Hearts mentioned this pull request Aug 8, 2024
Closed
6 tasks
@yizha1 yizha1 modified the milestones: 1.2.0, 1.1.0 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Two-Hearts @vaninrao10 @priteshbandi @shizhMSFT @JeyJeyGao @yizha1