fix(ci): pass CODECOV_TOKEN to reusable-build.yml #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 89.32% 89.87% +0.54%
==========================================
Files 21 23 +2
Lines 1724 1590 -134
==========================================
- Hits 1540 1429 -111
+ Misses 149 120 -29
- Partials 35 41 +6 ☔ View full report in Codecov by Sentry. |
Two-Hearts
reviewed
Jul 2, 2024
This was referenced Jul 2, 2024
JeyJeyGao
added a commit
to notaryproject/notation-go
that referenced
this pull request
Jul 9, 2024
Depends on notaryproject/notation-core-go#209 Signed-off-by: Junjie Gao <[email protected]> --------- Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
mainbranch build are failed at the step to upload codecov because of lacking of codecov token: https://github.com/notaryproject/notation-core-go/actions/runs/9706110222/job/26789276954#step:5:32Reference: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow
Will update notation-go, tsp-client after this PR is merged.
Signed-off-by: Junjie Gao [email protected]