Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Timestamp #207

Merged
merged 86 commits into from
Jul 8, 2024
Merged

feat: Timestamp #207

merged 86 commits into from
Jul 8, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jun 20, 2024 •
edited
Loading

This PR adds timestamping support with tests.

@Two-Hearts
tsa
582a011 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
test
8d92e01 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
test
ac03000 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix hash
05b0463 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
212930a
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f859d84
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f39811a
@Two-Hearts
initial commit
8cfd74d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
cose
034e4cd 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
84661c3
@Two-Hearts
initial commits
01e4268 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
d0a39ce
@Two-Hearts
refactored to use tspclient-go
8ad3eab 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update tspclient-go
3e76750 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
test
5fc45dc 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
182af1a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolve conflicts
e780d70 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
8a4cd55 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f75c250
@Two-Hearts
fix bug
65fe878 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
bad5a7f 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix bug
3bbfdbb 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update sign
bf4ea64 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix JWS timestamp
e653780 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
fecb8d8
@Two-Hearts
updated tspclient-go
e085696 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated tsa cert validation
2338257 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added tsa request nonce support
952d151 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix typo
db08071 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix OCSP
7654060 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Jun 27, 2024
View reviewed changes
internal/oid.go Outdated Show resolved Hide resolved
revocation/ocsp/ocsp.go Outdated Show resolved Hide resolved
revocation/ocsp/ocsp.go Outdated Show resolved Hide resolved
revocation/revocation.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
timestamp/timestamp.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
timestamp/timestamp.go Outdated Show resolved Hide resolved
x509/cert_validations.go Outdated Show resolved Hide resolved
x509/cert_validations.go Outdated Show resolved Hide resolved
@JeyJeyGao
Copy link
Contributor

Waiting for your update for Shiwei's comments.

@Two-Hearts
updated per code review
7ee9155 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
44714e2 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from shizhMSFT June 28, 2024 10:28
@Two-Hearts
update
906d41a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
de8a46c 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
clean up
c3a9244 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Jul 1, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/timestamp/timestamp.go Outdated Show resolved Hide resolved
revocation/ocsp/ocsp.go Outdated Show resolved Hide resolved
revocation/ocsp/ocsp.go Show resolved Hide resolved
revocation/revocation.go Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/jws/envelope.go Outdated Show resolved Hide resolved
x509/codesigning_cert_validations.go Outdated Show resolved Hide resolved
x509/timestamp_cert_validations.go Outdated Show resolved Hide resolved
x509/timestamp_cert_validations.go Outdated Show resolved Hide resolved
Two-Hearts added 4 commits July 1, 2024 22:19
@Two-Hearts
updated per code review
42d5b83 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added tests
4cb711b 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
89251f1 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated tspclient-go
66dd339 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from shizhMSFT July 2, 2024 01:31
Two-Hearts added 3 commits July 2, 2024 14:48
@Two-Hearts
updated tspclient-go
8c1e9cd 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
a810785 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
clean up
0830984 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Jul 2, 2024
View reviewed changes
signature/types.go Outdated Show resolved Hide resolved
x509/codesigning_cert_validations.go Outdated Show resolved Hide resolved
x509/codesigning_cert_validations.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit faac9b7 into notaryproject:main Jul 8, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the tsa branch July 8, 2024 01:59
@Two-Hearts Two-Hearts mentioned this pull request Jul 22, 2024
Closed
6 tasks
@Two-Hearts Two-Hearts mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @JeyJeyGao @priteshbandi @shizhMSFT