Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated Notary v2 to Notary Project #146

Merged
merged 3 commits into from
May 23, 2023

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented May 22, 2023

This chore PR resolves #127.

This PR also upgraded dependencies of the library.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #146 (9add51f) into main (0206650) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          21       21           
  Lines        1693     1693           
=======================================
  Hits         1509     1509           
  Misses        149      149           
  Partials       35       35           
Impacted Files Coverage Δ
signature/jws/types.go 100.00% <ø> (ø)
signature/types.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

The new feature of untagged COSE_Sign1 will not impact notation signature parsing.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a0cb09e into notaryproject:main May 23, 2023
@Two-Hearts Two-Hearts deleted the chore branch May 23, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references from Notary v2 to Notation
5 participants