Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: tag v1.2.0-rc.2 #248

Closed
4 of 6 tasks
Two-Hearts opened this issue Dec 6, 2024 · 9 comments
Closed
4 of 6 tasks

vote: tag v1.2.0-rc.2 #248

Two-Hearts opened this issue Dec 6, 2024 · 9 comments

Comments

@Two-Hearts
Copy link
Contributor

Two-Hearts commented Dec 6, 2024

Release

This would mean tagging 2cd55de as v1.2.0-rc.2 to release.

Vote

We need at least 4 approvals from 6 maintainers to release v1.2.0-rc.2.

Changes

Full Changelog:
v1.2.0-rc.1...2cd55de

Action Requested

Please respond LGTM or REJECT (with reasoning).

@vaninrao10
Copy link

LGTM

@Two-Hearts
Copy link
Contributor Author

We need a re-vote as tspclient-go dependency needs to be updated.

@shizhMSFT
Copy link
Contributor

We need a re-vote as tspclient-go dependency needs to be updated.

Agreed as we need #249

@Two-Hearts
Copy link
Contributor Author

#249 has been merged. Now we are ready for the re-vote.

@Two-Hearts
Copy link
Contributor Author

LGTM

3 similar comments
@JeyJeyGao
Copy link
Contributor

LGTM

@shizhMSFT
Copy link
Contributor

LGTM

@vaninrao10
Copy link

LGTM

@Two-Hearts
Copy link
Contributor Author

Closing as release completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants