Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSA certificate chain revocation check after timestamping #237

Closed
Two-Hearts opened this issue Oct 25, 2024 · 0 comments · Fixed by #246
Closed

TSA certificate chain revocation check after timestamping #237

Two-Hearts opened this issue Oct 25, 2024 · 0 comments · Fixed by #246
Assignees
@Two-Hearts
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@Two-Hearts
Copy link
Contributor

Two-Hearts commented Oct 25, 2024 •
edited
Loading

We should consider adding an option for users to enable tsa cert chain revocation check after timestamping.
Currently this is done during verification only, but we can fail fast on the signing side.
@Two-Hearts Two-Hearts added enhancement New feature or request triage triage labels Oct 25, 2024
@Two-Hearts Two-Hearts changed the title Certificate chain revocation check during signing Certificate chain revocation check after signing Oct 25, 2024
@yizha1 yizha1 assigned Two-Hearts and unassigned JeyJeyGao Nov 26, 2024
@yizha1 yizha1 removed the triage triage label Nov 26, 2024
@yizha1 yizha1 added this to the 1.2.0 milestone Nov 26, 2024
@Two-Hearts Two-Hearts changed the title Certificate chain revocation check after signing TSA certificate chain revocation check after timestamping Nov 26, 2024
@Two-Hearts Two-Hearts mentioned this issue Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Two-Hearts Two-Hearts

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

fix: add tsa cert chain revocation check after timestamping Two-Hearts/notation-core-go
3 participants
@JeyJeyGao @yizha1 @Two-Hearts