Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCSP request missing logs #223

Closed
JeyJeyGao opened this issue Aug 20, 2024 · 0 comments · Fixed by #235
Closed

OCSP request missing logs #223

JeyJeyGao opened this issue Aug 20, 2024 · 0 comments · Fixed by #235
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JeyJeyGao
Copy link
Contributor

JeyJeyGao commented Aug 20, 2024

What is not working as expected?

We have refactored the revocation interface to be

// Validator is an interface that provides revocation checking with
// context
type Validator interface {
	// ValidateContext checks the revocation status given caller provided options
	// and returns an array of CertRevocationResults that contain the results
	// and any errors that are encountered during the process
	ValidateContext(ctx context.Context, validateContextOpts ValidateContextOptions) ([]*result.CertRevocationResult, error)
}

The OCSP package should use the ctx when sending the request to write the logs.

http.NewRequestWithContext(ctx, http.MethodGet, url, nil)

What did you expect to happen?

No

How can we reproduce it?

No

Describe your environment

Source code

What is the version of your notation-core-go Library?

v1.1.0-rc.1

@JeyJeyGao JeyJeyGao added the enhancement New feature or request label Aug 20, 2024
@JeyJeyGao JeyJeyGao added the triage triage label Aug 27, 2024
@yizha1 yizha1 removed the triage triage label Sep 3, 2024
@yizha1 yizha1 added this to the 1.2.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants