Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GUN instead of ImageName to show that notary is not only for docker image #1069

Closed
HuKeping opened this issue Jan 4, 2017 · 3 comments
Closed

Comments

@HuKeping
Copy link
Contributor

HuKeping commented Jan 4, 2017

Since Notary is not only used for signing Docker image, it can be used to allows anyone to have trust over arbitrary collections of data . So we should probably not use imageName as the GUN ( Globally Unique Names ) to identify trust collections.

We should also add some other demo/document for the non-signing-docker-image use cases, although it is not the priority task.

See https://github.com/docker/notary/blob/master/server/server.go#L152
and maybe some other place.

@endophage
Copy link
Contributor

I don't disagree with anything you've stated, but it's internal and most users will never see the URL templating. I'd accept a PR changing it to gun but I'm kind of indifferent.

If we mix it up in the docs anywhere, we'd definitely want to change it there.

@HuKeping
Copy link
Contributor Author

HuKeping commented Jan 5, 2017

Aha, I'm not feeling very strong about it also, it's just when I reading some code and find that we are using the imageName where it seems should be better to use gun. Of course most user will not see that though.

@ecordell
Copy link
Contributor

This was done in #1081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants