Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatted I/O #1014

Closed
HuKeping opened this issue Oct 21, 2016 · 3 comments · Fixed by #1044
Closed

Fix formatted I/O #1014

HuKeping opened this issue Oct 21, 2016 · 3 comments · Fixed by #1044
Labels
Help Wanted Newcomer Friendly
Milestone
Notary 1.0

Comments

@HuKeping
Copy link
Contributor

HuKeping commented Oct 21, 2016 •
edited
Loading

https://github.com/docker/notary/blob/master/trustpinning/certs.go#L143

logrus.Debugf("checking root against trust_pinning config", gun)

We can either use logrus.Debug or add the %s to it.
@HuKeping HuKeping modified the milestone: Notary 1.0 Oct 21, 2016
@ecordell
Copy link
Contributor

see: https://github.com/docker/notary/pull/942/files#diff-4a6abebbf46d656cef390e6049c5f356L143

@riyazdf
Copy link
Contributor

riyazdf commented Oct 21, 2016

@ecordell @HuKeping - that's definitely a great fix. Happy to have that in a separate PR as well if we want to fast-track it.

@HuKeping
Copy link
Contributor Author

HuKeping commented Oct 22, 2016 •
edited
Loading

Thanks @ecordell ! I'll leave a closes link from that PR to here

@ecordell ecordell mentioned this issue Oct 22, 2016
Merged
@endophage endophage mentioned this issue Nov 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Newcomer Friendly
Projects
None yet
Milestone
Notary 1.0
Development

Successfully merging a pull request may close this issue.

fixing formatting in debugf endophage/notary
3 participants
@ecordell @riyazdf @HuKeping