From e5b604062cb1364fa93cbc28bc17265dd086b47c Mon Sep 17 00:00:00 2001
From: caichangheng <caichangheng001@outlook.com>
Date: Fri, 22 Mar 2024 02:31:50 +0800
Subject: [PATCH] Check preTags and postTags params for empty values (#106396)

Check highlighter params of pre_tags and post_tags params for empty values.

If empty throw IllegalArgumentException.

Closes #69009
---
 docs/changelog/106396.yaml                    |  6 ++
 .../test/search.highlight/issue69009.yml      | 72 +++++++++++++++++++
 .../highlight/AbstractHighlighterBuilder.java |  3 +
 .../highlight/HighlightBuilderTests.java      |  4 +-
 4 files changed, 83 insertions(+), 2 deletions(-)
 create mode 100644 docs/changelog/106396.yaml
 create mode 100644 rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.highlight/issue69009.yml

diff --git a/docs/changelog/106396.yaml b/docs/changelog/106396.yaml
new file mode 100644
index 0000000000000..7aa06566c75e7
--- /dev/null
+++ b/docs/changelog/106396.yaml
@@ -0,0 +1,6 @@
+pr: 106396
+summary: "Check preTags and postTags params for empty values"
+area: Highlighting
+type: bug
+issues:
+  - 69009
diff --git a/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.highlight/issue69009.yml b/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.highlight/issue69009.yml
new file mode 100644
index 0000000000000..8b2f2f90dd0ee
--- /dev/null
+++ b/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.highlight/issue69009.yml
@@ -0,0 +1,72 @@
+setup:
+  - skip:
+      version: ' - 8.13.99'
+      reason: 'check of preTags and postTags params for empty values was added in 8.14'
+
+  - do:
+      indices.create:
+        index: test
+        body:
+          mappings:
+            "properties":
+              "text":
+                "type": "text"
+                "term_vector": "with_positions_offsets"
+
+  - do:
+      index:
+        index: test
+        id:    "1"
+        body:
+          "text" : "The quick brown fox is brown."
+  - do:
+      indices.refresh: {}
+
+---
+"Test with empty pre_tags or post_tags in query body with unified highlight type - should fail" :
+  - do:
+      catch: /pre_tags or post_tags must not be empty/
+      search:
+        index: test
+        body: {
+          "query": { "match": { "fox" } },
+          "highlight": {
+            "type": "unified",
+            "fields": { "*": { } },
+            "pre_tags": [ ],
+            "post_tags": [ ]
+          },
+        }
+
+---
+"Test with empty pre_tags or post_tags in query body with plain highlight type - should fail" :
+  - do:
+      catch: /pre_tags or post_tags must not be empty/
+      search:
+        index: test
+        body: {
+          "query": { "match": { "fox" } },
+          "highlight": {
+            "type": "plain",
+            "fields": { "*": { } },
+            "pre_tags": [ ],
+            "post_tags": [ ]
+          },
+        }
+
+---
+"Test with empty pre_tags or post_tags in query body with fvh highlight type - should fail" :
+  - do:
+      catch: /pre_tags or post_tags must not be empty/
+      search:
+        index: test
+        body: {
+          "query": { "match": { "fox" } },
+          "highlight": {
+            "type": "fvh",
+            "fields": { "*": { } },
+            "pre_tags": [ ],
+            "post_tags": [ ]
+          },
+        }
+
diff --git a/server/src/main/java/org/elasticsearch/search/fetch/subphase/highlight/AbstractHighlighterBuilder.java b/server/src/main/java/org/elasticsearch/search/fetch/subphase/highlight/AbstractHighlighterBuilder.java
index d91b6e8b4e4a3..80cc459569dea 100644
--- a/server/src/main/java/org/elasticsearch/search/fetch/subphase/highlight/AbstractHighlighterBuilder.java
+++ b/server/src/main/java/org/elasticsearch/search/fetch/subphase/highlight/AbstractHighlighterBuilder.java
@@ -643,6 +643,9 @@ static <HB extends AbstractHighlighterBuilder<HB>> BiFunction<XContentParser, HB
                 if (hb.preTags() != null && hb.postTags() == null) {
                     throw new ParsingException(p.getTokenLocation(), "pre_tags are set but post_tags are not set");
                 }
+                if (hb.preTags() != null && hb.postTags() != null && (hb.preTags().length == 0 || hb.postTags().length == 0)) {
+                    throw new ParsingException(p.getTokenLocation(), "pre_tags or post_tags must not be empty");
+                }
             } catch (IOException e) {
                 throw new RuntimeException(e);
             }
diff --git a/server/src/test/java/org/elasticsearch/search/fetch/subphase/highlight/HighlightBuilderTests.java b/server/src/test/java/org/elasticsearch/search/fetch/subphase/highlight/HighlightBuilderTests.java
index efa2456e31af5..c521ab5e047aa 100644
--- a/server/src/test/java/org/elasticsearch/search/fetch/subphase/highlight/HighlightBuilderTests.java
+++ b/server/src/test/java/org/elasticsearch/search/fetch/subphase/highlight/HighlightBuilderTests.java
@@ -610,8 +610,8 @@ public static HighlightBuilder randomHighlighterBuilder() {
     private static void setRandomCommonOptions(AbstractHighlighterBuilder highlightBuilder) {
         if (randomBoolean()) {
             // need to set this together, otherwise parsing will complain
-            highlightBuilder.preTags(randomStringArray(0, 3));
-            highlightBuilder.postTags(randomStringArray(0, 3));
+            highlightBuilder.preTags(randomStringArray(1, 3));
+            highlightBuilder.postTags(randomStringArray(1, 3));
         }
         if (randomBoolean()) {
             highlightBuilder.fragmentSize(randomIntBetween(0, 100));