From 8cebe89f0bcadf5b3bf05c57c34592042b01c2e4 Mon Sep 17 00:00:00 2001 From: Mark Tozzi Date: Tue, 30 Jan 2024 11:22:24 -0500 Subject: [PATCH] remove code I'd only commened out --- .../predicate/operator/arithmetic/Mul.java | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/arithmetic/Mul.java b/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/arithmetic/Mul.java index e52664d06901d..5210fcb10ad8f 100644 --- a/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/arithmetic/Mul.java +++ b/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/arithmetic/Mul.java @@ -31,26 +31,6 @@ public Mul(Source source, Expression left, Expression right) { ); } - /* - @Override - protected TypeResolution resolveType() { - if (childrenResolved() == false) { - return new TypeResolution("Unresolved children"); - } - - DataType l = left().dataType(); - DataType r = right().dataType(); - - // 1. both are numbers - if (DataTypes.isNullOrNumeric(l) && DataTypes.isNullOrNumeric(r)) { - return TypeResolution.TYPE_RESOLVED; - } - - return new TypeResolution(format(null, "[{}] has arguments with incompatible types [{}] and [{}]", symbol(), l, r)); - } - - */ - @Override public ArithmeticOperationFactory binaryComparisonInverse() { return Div::new;