Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract scene into separate crate #798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Sep 6, 2024

As said in #768:

Honestly, scene overall needs to go. It should be either heavily refactored or be extracted into a separate crate.

This PR does that by removing the scene logic from macroquad and only adding a small handler that the new macroquad-scene crate can use to register a few functions so that macroquad can interact with the scene as before.
Also moved were the scene-related tests, the state_machine module and the CapabilityTrait derive macro.

A simple implementation of the proposed new macroquad-scene crate can be found here: https://github.com/cyrgani/macroquad-scene

Supersedes #795 and #796 (and likely some more), fixes #723.

@not-fl3
Copy link
Owner

not-fl3 commented Sep 6, 2024

I do not want to touch anything in scene/coroutines until macroquad-0.5, and macroquad-0.5 is not goint to have any of this anyway.

@cyrgani
Copy link
Contributor Author

cyrgani commented Sep 7, 2024

Will there be a replacement for it in 0.5?

@not-fl3
Copy link
Owner

not-fl3 commented Sep 7, 2024

I don't think so.
Just as you said, it should be a crate!

@cyrgani
Copy link
Contributor Author

cyrgani commented Sep 8, 2024

I'll keep this waiting until 0.5 is near, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tweens::linear is unsound
2 participants