Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-missing-placeholders and no-unused-placeholders to handle messageIds #252

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

bmish
Copy link
Member

@bmish bmish commented Jun 20, 2022

Fixes the second part of #57.

Correct placeholder with messageId example:

module.exports = {
    meta: {
        messages: { myMessageId: 'foo {{bar}}' } 
    },
    create(context) {
        context.report({
            node,
            messageId: 'myMessageId',
            data: { bar: 'baz' }
        });
    }
};

Part of the V5 release (#230).

@bmish bmish added the BREAKING CHANGE This change will require a major version bump label Jun 20, 2022
@bmish bmish mentioned this pull request Jun 20, 2022
@bmish bmish force-pushed the placeholder-messageids branch 2 times, most recently from a74d1f6 to a5b17cc Compare June 20, 2022 02:37
@aladdin-add
Copy link
Contributor

It's helpful, just wondering if we can land it in a minor release - as eslint's semantic versioning saying, it is possible to report more errors in a minor release?

@bmish bmish force-pushed the placeholder-messageids branch from a5b17cc to b686acc Compare July 4, 2022 14:57
@bmish bmish force-pushed the placeholder-messageids branch from b686acc to d7461a3 Compare July 4, 2022 14:59
@bmish bmish marked this pull request as ready for review July 7, 2022 17:03
@bmish
Copy link
Member Author

bmish commented Jul 7, 2022

It's helpful, just wondering if we can land it in a minor release - as eslint's semantic versioning saying, it is possible to report more errors in a minor release?

@aladdin-add maybe but I would still lean toward treating this as a breaking change. Since the v5 release (#230) is imminent, I think we should just include it in that major release.

@aladdin-add aladdin-add merged commit 047b0b5 into eslint-community:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants