Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nests breaks damus follows #33

Open
alltheseas opened this issue Apr 20, 2024 · 8 comments
Open

Nests breaks damus follows #33

alltheseas opened this issue Apr 20, 2024 · 8 comments

Comments

@alltheseas
Copy link
Collaborator

client initiating action

Nests

It all started after following a person on nosternests. Downhill from there.

client receiving or observing action (or lack thereof)

Damus

timestamp

https://damus.io/nevent1qqsyhe2ekdggdthgn45k5j99mgrqrygsv3taxeqmgyaukgcfu7t6xwqzff7rr

image

what happens

Lost followers

suggestion

@v0l

@alltheseas alltheseas changed the title Nests breaks damus Nests breaks damus follows Apr 20, 2024
@alltheseas
Copy link
Collaborator Author

Apps other than Damus reported affected

@alltheseas
Copy link
Collaborator Author

alltheseas commented Apr 21, 2024

@Semisol
Copy link

Semisol commented May 8, 2024

I believe the root cause is Nests has a bug where it puts an encoded npub in the p tag.

@alltheseas
Copy link
Collaborator Author

I believe the root cause is Nests has a bug where it puts an encoded npub in the p tag.

What's the best way to fix? Get to @derekross and @v0l attention?

Can you submit a PR @Semisol ?

@alltheseas
Copy link
Collaborator Author

@fiatjaf who is the dev / maintainer of the nostr dot com list restore tools?

The user submitting the feedback here is saying the restore tools do not work in his case.

@jb55
Copy link
Collaborator

jb55 commented May 9, 2024

the presence of an npub could fail a filter in Damus, which we can fix, but I don't see how the whole list could have been nuked.

@jb55
Copy link
Collaborator

jb55 commented May 9, 2024

but yeah should definitely add some tests for bad data in lists and see how that affects things. I could have swore we parse that out though when creating the filter...

@alltheseas
Copy link
Collaborator Author

Btw, side note that might help with troubleshooting.

I now understand what the blank notes are because I saw it glitch once.

The blank notes are not “missing data”

It’s a rendering issue, all the objectives that should be in the blank note will be render outside, like on top of another note for example, or outside of the view.

From bug reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants