Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the command "get_relays" in NIP46 is not well defined. #1619

Open
dukeh3 opened this issue Nov 30, 2024 · 1 comment
Open

the command "get_relays" in NIP46 is not well defined. #1619

dukeh3 opened this issue Nov 30, 2024 · 1 comment

Comments

@dukeh3
Copy link

dukeh3 commented Nov 30, 2024

Its difficult to understand what the field "get_relays" should return. Two interpretations are possible.

  1. This is the relays for the user that has signed in. I.E this tells the client, what relays to connect to on behalf of the user.

Example: Alice uses a remote-signer and connects her client to it, the client then connects the remote-signer to understand what relays Alice wants to use in here communication. This as oppose to getting this information from other places, like NIP 05. This mimics the behavior we have in NIP07. If this is the case it should be documented, by referencing NIP07. Also there should be a recommended order in the way its interpreted, IE should NIP05 take precedence over NIP07 / NIP46 or vice versa.

  1. The 'get_relays' returns relays that the remote-signer uses, and hence gives the client the option to select how to communicate with the remote-signer. This is relevant if the remote-signer does the login. I assume that this is not the case.
@staab
Copy link
Member

staab commented Dec 4, 2024

#2 should be handled in the bunker link, nip 89 handler, or nostrconnect link. Relying on the relays returned by get_relays is a chicken-and-egg problem. This could be clearer though, get_relays should probably return NIP 65 read/write relays, but it currently looks more like the undocumented kind 3 relays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants