fix: always trigger the switchChange event after a change event #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frapontillo thanks. i will take a look soon! |
LostCrew
pushed a commit
that referenced
this pull request
Dec 16, 2014
fix: always trigger the switchChange event after a change event
|
👍 |
|
@frapontillo will release this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 2 or more radio buttons, a change to the first radio button propagates correctly, while the change to the second one won't (as it is always skipped). This fixes it by propagating
switchChange.bootstrapSwitchafter everychange.bootstrapSwitch.Everything else keeps working.
Same as #349 but from the latest
developbranch.This is also needed to close frapontillo/angular-bootstrap-switch#46.