Skip to content

Commit

Permalink
test: move test-vm-break-on-sigint to sequential
Browse files Browse the repository at this point in the history 
This PR moves `test-vm-break-on-sigint.js` to sequential, following the
other PRs I have made to move CPU intensive tests into sequential. The
test has already been tuned to do less iterations in a previous PR.
However it is still causing ~7% of build failures. The timeouts seem
highly correlated with other tests which spawn a bunch of threads also
failing, see for example the [first Jenkins failure][] and the [last
Jenkins failure][].

[first Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45756/
[last Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45837/

Refs: nodejs/node#44090
Refs: nodejs/node#43981
Refs: nodejs/reliability#337
PR-URL: nodejs/node#44140
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
  • Loading branch information
@kvakil @guangwong
kvakil authored and guangwong committed Jan 3, 2023
1 parent dd8921f commit 5e10e0a
Showing 1 changed file with 0 additions and 0 deletions.
0 test/parallel/test-vm-break-on-sigint.js → test/sequential/test-vm-break-on-sigint.js
View file
File renamed without changes.

0 comments on commit 5e10e0a

Please sign in to comment.