Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): remove postinstall script, relax engine constraints #81

Merged
merged 6 commits into from
Jul 3, 2023
Merged

fix(package): remove postinstall script, relax engine constraints #81

merged 6 commits into from
Jul 3, 2023

Conversation

norskeld
Copy link
Owner

@norskeld norskeld commented Jul 3, 2023

This PR:

  • Removes postinstall npm script. I was thinking about prepare, but for some reason added postinstall. Anyway, both are meh, so ended up with manual npm run install:all command.
  • Adds install:all npm script to install dependencies for the package itself, as well as for docs and benchmarks to avoid issues when contributing. Also there's a short explanation in README now.
  • Relaxes engine (node) constraints a bit: from >=18.16.0 <=20 to >=18 to <=20.

Resolves #80

@norskeld norskeld added C-bug Category: Something is not working A-structure Area: Issues related to repository/code structure labels Jul 3, 2023
@norskeld norskeld self-assigned this Jul 3, 2023
@vercel
Copy link

vercel bot commented Jul 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sigma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 11:24pm

@norskeld norskeld merged commit 52dc1e4 into master Jul 3, 2023
@norskeld norskeld deleted the fix/install branch July 3, 2023 23:40
norskeld pushed a commit that referenced this pull request Jul 3, 2023
@semantic-release-bot
chore(release): release 3.6.4 [skip ci]
ec4d674 
## [3.6.4](v3.6.3...v3.6.4) (2023-07-03)

### Bug Fixes

* **package:** remove `postinstall` script, relax engine constraints ([#81](#81)) ([52dc1e4](52dc1e4)), closes [#80](#80)
@norskeld
Copy link
Owner Author

norskeld commented Jul 3, 2023

This PR is included in version 3.6.4.

@norskeld norskeld added the R-released Semantic Release: Success label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@norskeld norskeld

Labels
A-structure Area: Issues related to repository/code structure C-bug Category: Something is not working R-released Semantic Release: Success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postinstall fails on 3.6.3
1 participant
@norskeld