Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combinators/sepBy): do not mutate position on no match #79

Merged
merged 1 commit into from
Jun 4, 2023
Merged

fix(combinators/sepBy): do not mutate position on no match #79

merged 1 commit into from
Jun 4, 2023

Conversation

norskeld
Copy link
Owner

@norskeld norskeld commented Jun 4, 2023 •
edited
Loading

This fix is kindly provided by @gilbert. Thank you for your contribution!

Closes #77.

@norskeld norskeld self-assigned this Jun 4, 2023
@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sigma ✅ Ready (Inspect) Visit Preview Jun 4, 2023 0:28am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5169067679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5169050028: 0.0%
Covered Lines: 265
Relevant Lines: 265
💛 - Coveralls

@norskeld norskeld added A-combinators Area: Issues related to combinators C-bug Category: Something is not working labels Jun 4, 2023
@norskeld norskeld merged commit baf8c16 into master Jun 4, 2023
@norskeld norskeld deleted the fix/sepBy-mutates-pos-on-no-match branch June 4, 2023 13:32
norskeld pushed a commit that referenced this pull request Jun 4, 2023
@semantic-release-bot
chore(release): release 3.6.3 [skip ci]
5086a86 
## [3.6.3](v3.6.2...v3.6.3) (2023-06-04)

### Bug Fixes

* **combinators/sepBy:** do not mutate position on no match ([#79](#79)) ([baf8c16](baf8c16)), closes [#77](#77)
@norskeld
Copy link
Owner Author

norskeld commented Jun 4, 2023

This PR is included in version 3.6.3.

@norskeld norskeld added the R-released Semantic Release: Success label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@norskeld norskeld

Labels
A-combinators Area: Issues related to combinators C-bug Category: Something is not working R-released Semantic Release: Success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sepBy mutates position even on no match
2 participants
@norskeld @coveralls